Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify instructions about out-of-tree build #2

Closed
wants to merge 1 commit into from

Conversation

jserv
Copy link

@jserv jserv commented May 20, 2020

No description provided.

@PProvost
Copy link
Contributor

Interesting suggestion. Both sequences result in the same outcome. I'm curious why you prefer the long-winded version?

@jserv
Copy link
Author

jserv commented May 22, 2020

Interesting suggestion. Both sequences result in the same outcome. I'm curious why you prefer the long-winded version?

My intention was not to confuse users who are not familiar with CMake, so that they can simply copy-n-paste the instructions and ensure static library (maybe more objects are generated later) appears in the build directory without problems.

@PProvost
Copy link
Contributor

Fair enough. Since the two command sequences are identical in outcome, I'm going to leave the more terse form in place for now. If people get confused by it, we can reconsider.

I'm going to close this PR. Feel free to open an Issue if you want to continue this discuss. Thanks for your time on this.

@PProvost PProvost closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants