Skip to content

Commit

Permalink
callstack: Fix CompositeHostModel exit de-register
Browse files Browse the repository at this point in the history
Before this change, upon Trace Compass Eclipse application exit, there
was a "Resource leak" error in Console, about CompositeHostModel not
having been deregistered.

Dispose then for every InstrumentedCallStackAnalysis subclass, this way.

Add missing blank line at beginning of InstrumentedCallStackAnalysis for
consistency with sibling files, while there.

Change-Id: I5fbc1364d4e504417654fa796af356dad8ca42a8
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/199659
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
  • Loading branch information
marco-miller committed Mar 31, 2023
1 parent 93fa955 commit 5092431
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/

package org.eclipse.tracecompass.internal.analysis.callstack.core.instrumented;

import java.util.ArrayList;
Expand All @@ -30,6 +31,7 @@
import org.eclipse.tracecompass.internal.analysis.callstack.core.callgraph.CallGraph;
import org.eclipse.tracecompass.internal.analysis.callstack.core.callgraph.CallGraphAnalysis;
import org.eclipse.tracecompass.internal.analysis.callstack.core.callgraph.ICallGraphProvider;
import org.eclipse.tracecompass.internal.analysis.callstack.core.model.ModelManager;
import org.eclipse.tracecompass.internal.analysis.callstack.core.tree.IWeightedTreeGroupDescriptor;
import org.eclipse.tracecompass.segmentstore.core.ISegment;
import org.eclipse.tracecompass.segmentstore.core.ISegmentStore;
Expand Down Expand Up @@ -249,6 +251,7 @@ public String getTitle() {
public void dispose() {
super.dispose();
fCallGraph.dispose();
ModelManager.disposeModels();
}

@Override
Expand Down

0 comments on commit 5092431

Please sign in to comment.