Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix backend issues with policies and dsp endpoints/prepared v4.0.1 #388

Merged
merged 27 commits into from
Jul 25, 2024

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Jul 19, 2024

What we want to achieve with this PR?

I found a bug in the chart configuration, and now the release needs to be recreated, or at least the chart release
Additionally there were some issues that needed to be resolved regarding the edc 0.7.3 transfer and the irs integration.
#390
Some typos were also found in the dpp-verification documentation and needed to be fixed

What is new?

Added

  • Added unit tests for the dsp endpoint parsing functionality
  • Added digital product pass compatibility matrix file to the repo root path

Updated

  • Updated typos and missing explanations in the dpp-verification documentation.
  • Fixed typo in AttributeCertificationRecord which short name was amr, it was a typo and was corrected to acr.
  • Aligned charts for dpp-verification add-on configuration in the configmap -> #390
  • @deprecated old function to parse dsp endpoint with bpns.
  • Updated default INT urls to the Association INT environement url path.
  • Managed integration of latest IRS version chart: 7.4.0 and tested compatibility

Deleted

  • AssetId field removed from transfer-request model. Deprecated by the EDC v0.7.3 V3 Management Api -> #390

Issues Fixed

  • Fixed issue with dsp endpoint parsing/building from Digital Twin submodelBody field. -> #390
  • Fixed policy chart misconfiguration for the passport and digital twin registry -> #390

Related Issues

Closes #390

@matbmoser matbmoser added the helm-charts Issue or PR connected to the helm charts configuration label Jul 19, 2024

import static org.junit.jupiter.api.Assertions.*;

class CatenaXUtilTest {

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note test

Unused class: CatenaXUtilTest is not referenced within this codebase. If not used as an external API it should be removed.
@matbmoser matbmoser added this to the v4.0.1 milestone Jul 24, 2024
@matbmoser matbmoser added backend Issue or PR connected to the backend application R24.08 labels Jul 24, 2024
@matbmoser matbmoser changed the title chore: fixed dev chart configs policies chore: fix backend issues with policies and dsp endpoints/prepare v4.0.1 Jul 24, 2024
@matbmoser
Copy link
Contributor Author

matbmoser commented Jul 24, 2024

I am just waiting to have the "maven" repository to be working again so we can execute the IP checks

https://status.maven.org/

I have asked in the commiter matrix chat: https://chat.eclipse.org/#/room/!qZkRenDKdhqXlBVIfo:matrix.eclipse.org/$kaeZjRhB6YVDtbYVfmnV870a22EDhcKVlFOzXhMFFXc?via=matrix.eclipse.org&via=matrix.org

And apparently other products are having the same problem

@matbmoser
Copy link
Contributor Author

I could finally fix the problem!

@matbmoser
Copy link
Contributor Author

matbmoser commented Jul 24, 2024

image

By using the version of dash 1.1.1 that was last updated today, it will work

@matbmoser matbmoser self-assigned this Jul 24, 2024
@matbmoser matbmoser changed the title chore: fix backend issues with policies and dsp endpoints/prepare v4.0.1 chore: fix backend issues with policies and dsp endpoints/prepared v4.0.1 Jul 24, 2024
Copy link
Contributor

@saudkhan116 saudkhan116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matbmoser matbmoser merged commit dafa866 into main Jul 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issue or PR connected to the backend application helm-charts Issue or PR connected to the helm charts configuration R24.08
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DPP v4.0.0] Transfer issue parsing EDR in edc 0.7.3 in migration to /v3 api
2 participants