Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize Maven Target support shared with M2E #2434

Merged
merged 2 commits into from
May 29, 2023

Conversation

HannesWell
Copy link
Member

Copy changes from eclipse-m2e/m2e-core#1391

@github-actions
Copy link

github-actions bot commented May 24, 2023

Test Results

   549 files  ±0     549 suites  ±0   4h 17m 10s ⏱️ - 40m 41s
   347 tests ±0     341 ✔️ ±0    6 💤 ±0  0 ±0 
1 041 runs  ±0  1 022 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit 42acefc. ± Comparison against base commit 8b73c9b.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member Author

Looks like org.eclipse.aether.spi.synccontext.SyncContextFactory is only available since maven-resolver-spi 1.7, but Maven 3.8.7 only contains maven-resolver-spi 1.6.3.
In order to not require Maven 3.9 for Tycho is suggest to simply stay at the old class, that is deprecated with Maven 3.9.x.
The discrepancy to m2e is IMHO ok.

@laeubi
Copy link
Member

laeubi commented May 25, 2023

Tycho is supposed to use Maven 3.9 but it is not yet enforced.

@HannesWell
Copy link
Member Author

Tycho is supposed to use Maven 3.9 but it is not yet enforced.

Understand, updated the verify-platform workflows to use Maven 3.9.1.
It looks like until now it also worked with 3.8.6

@laeubi laeubi merged commit 075f12f into eclipse-tycho:master May 29, 2023
@HannesWell HannesWell deleted the mavenTargetsCleanUps branch May 29, 2023 11:15
@laeubi laeubi added this to the 4.0 milestone Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants