Fix DependencyComputer missing bundles when they have different versions #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the DependencyComputer sorts only by bundle name (even though the comment for the code mentions the version as well) this can lead to the situation that if a bundle requires the same bundle in different versions (e.g. because it has actually different package names like javax -> jakarta) it only gets one of both on the classpath even though the P2 input suggests both. This simply enhances the used key in the mak with the version as already suggested by the java comment.
laeubi
added
the
backport-to-tycho-4.0.x
HannesWell
reviewed
Sep 19, 2023
tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/DependencyComputer.java
Show resolved
Hide resolved
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the DependencyComputer sorts only by bundle name (even though the comment for the code mentions the version as well) this can lead to the situation that if a bundle requires the same bundle in different versions (e.g. because it has actually different package names like javax -> jakarta) it only gets one of both on the classpath even though the P2 input suggests both.
This simply enhances the used key in the mak with the version as already suggested by the java comment.