Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 3804 #3806

Merged
merged 2 commits into from
May 3, 2024
Merged

Pr 3804 #3806

merged 2 commits into from
May 3, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented May 3, 2024

FYI @HeikoKlare I have now used your testcase and added a fix on top of it.

HeikoKlare and others added 2 commits May 3, 2024 11:52
When using linked resources for a project's .classpath file defining a
JUnit classpath container or test source folders, they are not detected
by Tycho, such that the JUnit classpath container and the test source
folder are not considered during the build.

This adds a test case demonstrating the integration of the .classpath
file and a test source folder via linked resources.
Copy link

github-actions bot commented May 3, 2024

Test Results

396 files  ±0  396 suites  ±0   2h 27m 26s ⏱️ + 1m 7s
419 tests +1  412 ✅ +1   7 💤 ±0  0 ❌ ±0 
838 runs  +2  823 ✅ +2  15 💤 ±0  0 ❌ ±0 

Results for commit 37a672a. ± Comparison against base commit c052150.

@laeubi laeubi merged commit 93b53da into eclipse-tycho:main May 3, 2024
10 of 11 checks passed
@HeikoKlare
Copy link
Contributor

HeikoKlare commented May 3, 2024

Thank you so much for fixing this, @laeubi! That was very fast.

I've also validated the fix using the current Tycho 4.0.8 snapshot version for the SWT use case (eclipse-platform/eclipse.platform.swt#1203). Everything works as expected 👍

Do you think we could use the Tycho 4.0.8 snapshot version in the eclipse platform parent to have this fix available in the platform builds until 4.0.8 is finally released?

@laeubi
Copy link
Member Author

laeubi commented May 4, 2024

Here we go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants