Synthesize a (bnd) clazz from the JDT model to support export annotation #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export annotations are already parsed and the package is given to the analyzer, but if no export instruction is present the bnd analyzer does throw them away as it does not know about it in a later stage. This now synthesize a (bnd) class to emulate what the analyzer would see for a real class file and inject that instance into the analyzer so the package is finally considdered.
laeubi
added
the
backport-to-tycho-4.0.x
Test Results 594 files 594 suites 3h 54m 18s ⏱️ Results for commit e315bb3. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export annotations are already parsed and the package is given to the analyzer, but if no export instruction is present the bnd analyzer does throw them away as it does not know about it in a later stage.
This now synthesize a (bnd) class to emulate what the analyzer would see for a real class file and inject that instance into the analyzer so the package is finally considdered.