Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove utils::Base64 #214

Closed
gregmedd opened this issue Jul 11, 2024 · 1 comment · Fixed by #222
Closed

Remove utils::Base64 #214

gregmedd opened this issue Jul 11, 2024 · 1 comment · Fixed by #222
Assignees
@gregmedd
Milestone
alpha.2

Comments

@gregmedd
Copy link
Contributor

It is unclear what this is needed for, and it certainly won't block the critical path.

Alternatively, it can be removed if we don't need it.
@gregmedd gregmedd converted this from a draft issue Jul 11, 2024
@gregmedd gregmedd self-assigned this Jul 11, 2024
@gregmedd
Copy link
Contributor Author

We did not need it for the 1.0.0 (alpha.2) release. The header will be removed. We can retrieve it from the repo history if we need it in the future.

@gregmedd gregmedd changed the title Implement and test (or remove) utils::Base64 Remove utils::Base64 Jul 11, 2024
@gregmedd gregmedd added this to the alpha.2 milestone Jul 11, 2024
gregmedd added a commit to gregmedd/up-cpp that referenced this issue Jul 12, 2024
@gregmedd
Removing unused utility stubs
9063ed4 
These utilities were not needed for the 1.0.0 release of up-cpp, so
they're being removed from the release branch.

See eclipse-uprotocol#214 eclipse-uprotocol#215 eclipse-uprotocol#216 eclipse-uprotocol#217
@gregmedd gregmedd mentioned this issue Jul 12, 2024
Merged
gregmedd added a commit to gregmedd/up-cpp that referenced this issue Jul 12, 2024
@gregmedd
Removing unused utility stubs
33f27be 
These utilities were not needed for the 1.0.0 release of up-cpp, so
they're being removed from the release branch.

See eclipse-uprotocol#214 eclipse-uprotocol#215 eclipse-uprotocol#216 eclipse-uprotocol#217
This was linked to pull requests Jul 12, 2024
Use the same build commands in CI as listed in README #231
Merged
Removing unused utility stubs #222
Merged
@gregmedd gregmedd removed a link to a pull request Jul 12, 2024
Use the same build commands in CI as listed in README #231
Merged
@gregmedd gregmedd moved this from Ready to Done in C++ uProtocol Development Jul 12, 2024
@gregmedd gregmedd closed this as completed by moving to Done in C++ uProtocol Development Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregmedd gregmedd

Labels
None yet
Projects
C++ uProtocol Development
Status: Done
Milestone
alpha.2
Development

Successfully merging a pull request may close this issue.

Removing unused utility stubs gregmedd/up-cpp
1 participant
@gregmedd