fixes #1602: NetClient with SOCKS Proxy checks wrong hostname on upgradeToSsl() #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tname on upgradeToSsl() pass the host to from NetClient connect to NetSocket and use actual address of host when using upgradeToSsl to check ssl cert add unit test for ssl connect and ssl upgrade with SOCKS proxy to NetTest remove a few NetServer close/reopen in a few tests where it was not needed Signed-off-by: alexlehm <alexlehm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a rather unlikely usecase when connecting with a SOCKS proxy to a service that requires upgradeToSsl
e.g. STARTTLS in SMTP, since the ssl helper is constructed with the target address of the tcp connection, the cert is checked against the proxy address (e.g. localhost) instead of the actual address (e.g. smtp.gmail.com)