Configurable server port for the vertx test using HttpTestBase.DEFAULT_HTTP_PORT

[percyashu]

Motivation: discussion

HttpTestBase.DEFAULT_HTTP_PORT could be loaded from a system property or be 8080 when there is no such system property. So it can be used instead of hard coding port 8080 in tests.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

[percyashu]

Hi @vietj and @tsegismont,
This is ready for review.

[vietj]

we should also do the same for the HTTPS port DEFAULT_HTTPS_PORT in this PR.

[percyashu]

@vietj the changes requested have been applied and ready for review.

[vietj]

will have a look soon, can you prepare a backport PR for vert 4.x branch @percyashu ?

[percyashu]

will have a look soon, can you prepare a backport PR for vert 4.x branch @percyashu ?

@vietj I don't quite understand how to do a backport PR but I am willing to prepare it with some explanation.

[vietj]

will have a look soon, can you prepare a backport PR for vert 4.x branch @percyashu ?

@vietj I don't quite understand how to do a backport PR but I am willing to prepare it with some explanation.

actually never mind, there is already a pull request there.

[vietj]

as said in the other PR, can you just revert the tests that actually tests objects (like HostAndPortTest) that do not use a real server ? that is preferable.

[vietj]

thanks, I will merge that tomorrow