Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: more eventbus and HTTP tags #5024

Merged

Conversation

tsegismont
Copy link
Contributor

@tsegismont tsegismont commented Dec 8, 2023

Olamide Kolawole and others added 2 commits December 8, 2023 17:50
- In Vert.x 4, use OpenTracing prefixes
- Take latest OTel spec into account https://opentelemetry.io/docs/specs/semconv/http/http-spans

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont merged commit 3f3a6b2 into eclipse-vertx:4.x Dec 11, 2023
7 checks passed
tsegismont added a commit that referenced this pull request Dec 11, 2023
* emit tags suitable for OpenTelemetry 1.18 Semantic Conventions

* Tag names updates

- In Vert.x 4, use OpenTracing prefixes
- Take latest OTel spec into account https://opentelemetry.io/docs/specs/semconv/http/http-spans

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>

---------

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Co-authored-by: Olamide Kolawole <olamshin@gmail.com>
@tsegismont tsegismont deleted the Olamshin-otel_semantic_conventions branch December 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants