Add test executables for different configurations #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
8745cf7
to
777d526
Compare
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
8 times, most recently
from
49a85f1
to
3a89ada
Compare
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
3a89ada
to
597e111
Compare
mlasch
reviewed
Nov 20, 2023
.cmake-format
Outdated
| "COMPILE_DEFINITIONS": '*', | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The newline has gone missing here.
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
597e111
to
f306a29
Compare
mlasch
approved these changes
Nov 21, 2023
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
f306a29
to
9c2960e
Compare
The registration code is disabled at compile time if we do not set the define for building a server.
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
9c2960e
to
1c3ddbd
Compare
In some cases a random byte pattern was interpreted as a boolean type. This happend when the conversion to a bool was not successful but its value was logged anyway.
The same tests are compiled with different defines to make sure that combinations of different configurations work properly.
LukasWoodtli
force-pushed
the
gardena/lw/tests_with_different_defines
branch
from
1c3ddbd
to
189da07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same tests are compiled and ran with different defines to make sure that combinations of different configurations work properly.
Some combinations of defines are added. This can be extended to include other interesting configuration combinations.