Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prv_getParameters / fix query len check #737

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

semhoun
Copy link
Contributor

@semhoun semhoun commented Nov 16, 2023

When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN.
It's like an erronous copy/paste.

@rettichschnidi
Copy link
Contributor

rettichschnidi commented Nov 16, 2023

Thanks for your PR, nice catch! Before we can integrate, please sign the ECA.

@semhoun
Copy link
Contributor Author

semhoun commented Nov 17, 2023

I signed the ECA.

@rettichschnidi
Copy link
Contributor

rettichschnidi commented Nov 17, 2023

CI requires a commit to have a body. If you annotate amend the commit with what you described in the PR, CI will pass.

Copy link
Contributor Author

@semhoun semhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN.
It's like an erronous copy/paste.

Copy link
Contributor Author

@semhoun semhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i don't know how to annotate a commit after pushin it.

When the query is QUERY_QUEUE_MODE test of the len is compared with
QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN.

It's like an erronous copy/paste.
@rettichschnidi
Copy link
Contributor

Sorry, amend is what I meant (git commit --amend). You can read up on how to do this here.

Since you allowed maintainer edits, I just massaged the commit a bit, so it (hopefully) passes the CI. Will merge once it does.

Thanks a lot!

@semhoun
Copy link
Contributor Author

semhoun commented Nov 17, 2023

Thanks, i will know for the future.

@rettichschnidi rettichschnidi merged commit 4a85dde into eclipse-wakaama:master Nov 17, 2023
31 checks passed
@semhoun semhoun deleted the fix/queue_mode branch February 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants