-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prv_getParameters / fix query len check #737
Conversation
Thanks for your PR, nice catch! Before we can integrate, please sign the ECA. |
I signed the ECA. |
CI requires a commit to have a body. If you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN.
It's like an erronous copy/paste.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i don't know how to annotate a commit after pushin it.
b282856
to
80822e0
Compare
When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN. It's like an erronous copy/paste.
80822e0
to
5a265e2
Compare
Sorry, amend is what I meant ( Since you allowed maintainer edits, I just massaged the commit a bit, so it (hopefully) passes the CI. Will merge once it does. Thanks a lot! |
Thanks, i will know for the future. |
When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN.
It's like an erronous copy/paste.