Lw/logging improvements #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If logging is disabled (or some log levels are diabled), the logging macros are expanded to nothing. This leaves an unneeded semicolon in the code.
The legacy logging macro has been replaced with the new way for logging URI's.
The legacy logging macros have been replaced with the new way of logging.
LukasWoodtli
force-pushed
the
lw/logging_improvements
branch
2 times, most recently
from
152ec58
to
f00b8aa
Compare
Two case statements were identical. They are now combined into one.
LukasWoodtli
force-pushed
the
lw/logging_improvements
branch
from
f00b8aa
to
326d374
Compare
|
|
Looks good |
mlasch
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.