Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Guava Lists.newArrayList(); with new ArrayList<>(); #270

Closed
vogella opened this issue Jun 7, 2022 · 1 comment · Fixed by #663
Closed

Replace Guava Lists.newArrayList(); with new ArrayList<>(); #270

vogella opened this issue Jun 7, 2022 · 1 comment · Fixed by #663
Milestone
1.15.0

Comments

@vogella
Copy link
Contributor

vogella commented Jun 7, 2022

AFAICS Guava Lists.newArrayList(); simply delegates to new ArrayList<>(); in WB therefore we can use this standard Java construct.
vogella added a commit to MarcelduPreez/windowbuilder that referenced this issue Jun 7, 2022
@vogella
Replace Guava Lists.newArrayList(); with new ArrayList<>() in
cb0d755 
ComponentsPropertiesPage

First change for eclipse-windowbuilder#270 but usage of Lists.newArrayList() is still present
in lots of other files.
vogella added a commit to vogellacompany/windowbuilder that referenced this issue Jun 7, 2022
@vogella
Replace Guava Lists.newArrayList(); with new ArrayList<>() in
d53381a 
ComponentsPropertiesPage

First change for eclipse-windowbuilder#270 but usage of Lists.newArrayList() is still present
in lots of other files.
@vogella vogella mentioned this issue Jun 7, 2022
Closed
vogella added a commit that referenced this issue Jun 7, 2022
@vogella
Replace Guava Lists.newArrayList(); with new ArrayList<>() in
1ef76ce 
ComponentsPropertiesPage

First change for #270 but usage of Lists.newArrayList() is still present
in lots of other files.
@ptziegler ptziegler mentioned this issue Sep 28, 2023
Merged
This was referenced Oct 30, 2023
Merged
Merged
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 11, 2023
@ptziegler
Remove calls to Guavas Lists/Iterables methods eclipse-windowbuilder#270
5bb0af1 


In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

List.transform() or Iterables.filter() can be replaced by the Java
Stream API, which is also encouraged by their JavaDoc.

Occasionally, we use List.of() to create lists from arrays. But care has
to be taken here, because those lists are read-only. If values are
written to them afterwards, the constructed list is passted as an
argument to an ArrayList.

The MapMaker class which is used to create maps with weak keys/values
are replaced by the ReferenceMap.

The Multimap class is replaced by the MultiValueMap.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 11, 2023
@ptziegler
Remove calls to Guavas Lists/Iterables methods eclipse-windowbuilder#270
18b3506 


In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

List.transform() or Iterables.filter() can be replaced by the Java
Stream API, which is also encouraged by their JavaDoc.

Occasionally, we use List.of() to create lists from arrays. But care has
to be taken here, because those lists are read-only. If values are
written to them afterwards, the constructed list is passted as an
argument to an ArrayList.

The MapMaker class which is used to create maps with weak keys/values
are replaced by the ReferenceMap.

The Multimap class is replaced by the MultiValueMap.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 11, 2023
@ptziegler
Remove usage of Guava Collections in WindowBuilder Core eclipse-windo…
d4f3eec 
…wbuilder#270

In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

Occasionally, we use Arrays.asList() to create lists from arrays. But
care has to be taken here, because those lists are read-only. If values
are written to them afterwards, the constructed list is passed as an
argument to an ArrayList.
Note that we use Arrays.asList() instead of List.of(), as latter doesn't
allow null elements.

The MapMaker class which is used to create maps with weak keys/values
are replaced by the ReferenceMap.

The Multimap class is replaced by the MultiValueMap.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 11, 2023
@ptziegler
Remove usage of Guava Collections in WindowBuilder Core eclipse-windo…
de94b19 
…wbuilder#270

In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

Occasionally, we use Arrays.asList() to create lists from arrays. But
care has to be taken here, because those lists are read-only. If values
are written to them afterwards, the constructed list is passed as an
argument to an ArrayList.
Note that we use Arrays.asList() instead of List.of(), as latter doesn't
allow null elements.

The MapMaker class which is used to create maps with weak keys/values
are replaced by the ReferenceMap.

The Multimap class is replaced by the MultiValueMap.
ptziegler added a commit that referenced this issue Dec 12, 2023
@ptziegler
Remove usage of Guava Collections in WindowBuilder Core #270
8b4801b 
In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

Occasionally, we use Arrays.asList() to create lists from arrays. But
care has to be taken here, because those lists are read-only. If values
are written to them afterwards, the constructed list is passed as an
argument to an ArrayList.
Note that we use Arrays.asList() instead of List.of(), as latter doesn't
allow null elements.

The MapMaker class which is used to create maps with weak keys/values
are replaced by the ReferenceMap.

The Multimap class is replaced by the MultiValueMap.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 13, 2023
@ptziegler
Remove usage of Guava collections from SWT/RCP projects eclipse-windo…
ac04cfe 
…wbuilder#270

In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

We occasionally have to use Arrays.asList() or List.of(), depending on
whether we expect null values and whether the list should be modifiable.
ptziegler added a commit that referenced this issue Dec 13, 2023
@ptziegler
Remove usage of Guava collections from SWT/RCP projects #270
da85dfc 
In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().

We occasionally have to use Arrays.asList() or List.of(), depending on
whether we expect null values and whether the list should be modifiable.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 13, 2023
@ptziegler
Remove usage of Guava collections from Swing projects eclipse-windowb…
907e9a0 
…uilder#270

In almost all cases, the call of Lists.newArrayList() can be simply
replaced with new ArrayList<>().
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 13, 2023
@ptziegler
Remove usage of Guava collections from Swing projects eclipse-windowb…
f5d9547 
…uilder#270

Minor occurrences of collections and iterables which can be easilly
expressed using native Java methods.
ptziegler added a commit that referenced this issue Dec 14, 2023
@ptziegler
Remove usage of Guava collections from Swing projects #270
96abbd1 
Minor occurrences of collections and iterables which can be easilly
expressed using native Java methods.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Remove usage of Guava collections from test project eclipse-windowbui…
f94f916 
…lder#270

Use Lists utility class from AssertJ project as drop-in replacement.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Remove usage of Guava collections from test project eclipse-windowbui…
3b0ae0c 
…lder#270

Use Lists utility class from AssertJ project as drop-in replacement.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Convert Iterables.filter() with Java8 Stream API eclipse-windowbuilde…
f857ec3 
…r#270
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Replace Guavas BiMap with BidiMap from Commons Collections eclipse-wi…
89991ae 
…ndowbuilder#270
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Remove project dependencies to Guava eclipse-windowbuilder#270
1f50d55
ptziegler added a commit that referenced this issue Dec 14, 2023
@ptziegler
Remove usage of Guava collections from test project #270
1bb032a 
Use Lists utility class from AssertJ project as drop-in replacement.
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Convert Iterables.filter() with Java8 Stream API eclipse-windowbuilde…
9ff3df4 
…r#270
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Replace Guavas BiMap with BidiMap from Commons Collections eclipse-wi…
dee6802 
…ndowbuilder#270
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Remove project dependencies to Guava eclipse-windowbuilder#270
5b4987c
@ptziegler ptziegler linked a pull request Dec 14, 2023 that will close this issue
Replace Guavas BiMap with BidiMap from Commons Collections #270 #663
Merged
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Replace Guavas BiMap with BidiMap from Commons Collections eclipse-wi…
7d8f952 
…ndowbuilder#270
ptziegler added a commit to ptziegler/windowbuilder that referenced this issue Dec 14, 2023
@ptziegler
Remove project dependencies to Guava eclipse-windowbuilder#270
96d7a27
ptziegler added a commit that referenced this issue Dec 14, 2023
@ptziegler
Convert Iterables.filter() with Java8 Stream API #270
5e4765b
ptziegler added a commit that referenced this issue Dec 14, 2023
@ptziegler
Replace Guavas BiMap with BidiMap from Commons Collections #270
f92bcf5
ptziegler added a commit that referenced this issue Dec 14, 2023
@ptziegler
Remove project dependencies to Guava #270
49073f8
@ptziegler
Copy link
Contributor

With #663, the last remaining dependency to Guava has been removed. We now either use the corresponding Java methods directly or Commons Collections (for e.g. BidiMaps).

@ptziegler ptziegler added this to the 1.15.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

Replace Guavas BiMap with BidiMap from Commons Collections #270 ptziegler/windowbuilder
2 participants
@vogella @ptziegler