fix(zenoh-flow-nodes): provide accessors on LinkMessage
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing the Python bindings highlighted a tiny nuisance of the `Deref`
trait: in order to access a Payload, an explicit turbofished call to
Deref was required, which was not particularly ergonomic.
This commit introduces accessors for both the `payload` and `timestamp`
fields of a `LinkMessage`.
The method `get_timestamp` was deprecated in favour of `timestamp`. This
change is purely aesthetic and for coherence purposes.
* zenoh-flow-nodes/src/messages.rs:
- removed the implementation of the Deref trait,
- added an accessor `payload()`,
- added an accessor `timestamp()`,
- deprecated the accessor `get_timestamp()` in favour of
`timestamp()`.
* zenoh-flow-runtime/src/runners/builtin/zenoh/sink.rs: as the Deref
trait is no longer implemented on `LinkMessage`, a call to `payload()`
is required.
Signed-off-by: Julien Loudet <julien.loudet@zettascale.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing the Python bindings highlighted a tiny nuisance of the
Dereftrait: in order to access a Payload, an explicit turbofished call to Deref was required, which was not particularly ergonomic.This commit introduces accessors for both the
payloadandtimestampfields of aLinkMessage.The method
get_timestampwas deprecated in favour oftimestamp. This change is purely aesthetic and for coherence purposes.payload(),timestamp(),get_timestamp()in favour oftimestamp().LinkMessage, a call topayload()is required.