Use wall time in throughput test #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the throughput tests should use the |
|
Agreed but that won't be possible until #183 has been addressed sadly. |
|
My bad... I've mistaken |
|
Ok it breaks windows build because of course. So either we resolve #183 before merging this or we resort to the z_ping trick: if(NOT(UNIX) AND(${target} STREQUAL "z_ping" OR ${target} STREQUAL "z_pong"))
continue()
endif() |
sashacmc
suggested changes
Dec 20, 2023
examples/z_sub_thr.c
Outdated
| return stats; | ||
| } | ||
|
|
||
| static inline unsigned long elapsed_us(const struct timespec *start, const struct timespec *end) { |
There was a problem hiding this comment.
It may be better to immediately return floating point seconds than to convert them further each time at the risk of making a mistake with the number of zeros.
examples/z_sub_thr.c
Outdated
| stats->finished_rounds++; | ||
| printf("%f msg/s\n", N * (double)CLOCKS_PER_SEC / (double)(stats->stop - stats->start)); | ||
| printf("%f msg/s\n", (double)N * 1000000.0 / (double)elapsed_us(&stats->start, &end)); |
There was a problem hiding this comment.
And we also don’t need type conversion every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughput test had the same issue of using system time instead of wall time as #184.
This PR switch this to wall time using
CLOCK_MONOTONIC.