-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New buffers and codec #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial, yet to be finished)
…td feature in zenoh-collections
…fmt::Format for all the types in zenoh-protocol that dependend in some way by defmt::Format being implemented for types in UHLC
p-avital
approved these changes
Jan 9, 2023
…tocol/codec -- now types with custom implementation of fmt::Debug/fmt::Display use those same implementations for defmt::Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors completely:
The proposed refactor brings:
impl
no_std
environmentno_std
. More work will be needed for protocol and codec.I'm marking this PR as draft although CI tests seem to be happy.
Before marking as non-draft, additional tests should be run with all zenoh binding, plugins, and backends:
BUILD_INTEGRATION=ON ARGS=-V make all; ZENOH_BRANCH=new-buffers ARGS=-V make test
is successful