Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New buffers and codec #383

Merged
merged 123 commits into from
Jan 10, 2023
Merged

New buffers and codec #383

merged 123 commits into from
Jan 10, 2023

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Nov 23, 2022

This PR refactors completely:

  1. Zenoh buffers
  2. Zenoh protocol codec

The proposed refactor brings:

  • Decoupling between actual protocol codec and buffer implementation
  • Different buffers can be used to serialize/deserialize zenoh messages
  • Changes to the protocol don't require changing the inherent buffer impl
  • It's a first for having basic protocol support (e.g. buffers, protocol, and codec) in a no_std environment
    • buffers are no_std. More work will be needed for protocol and codec.

I'm marking this PR as draft although CI tests seem to be happy.
Before marking as non-draft, additional tests should be run with all zenoh binding, plugins, and backends:

@Mallets Mallets marked this pull request as ready for review December 31, 2022 11:21
@Mallets Mallets merged commit 1082f90 into master Jan 10, 2023
@Mallets Mallets deleted the new-buffers branch January 10, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants