Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables locking #456

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Tables locking #456

merged 6 commits into from
Apr 4, 2023

Conversation

OlivierHecart
Copy link
Contributor

No description provided.

@OlivierHecart OlivierHecart added the enhancement Existing things could work better label Mar 28, 2023
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes allow to reduce the time a write lock is held on the tables upon reception of new declarations. However, the proposed changes seem to introduce a performance regression on the machine used to mesure Zenoh's performance (see https://zenoh.io/blog/2023-03-21-zenoh-vs-mqtt-kafka-dds/).

From 4.35M msg/s -> 4.05M msg/s with a data payload of 8 bytes (i.e., 300K msg/s went missing). I believe this should be further investigated before merging.

@Mallets
Copy link
Member

Mallets commented Apr 4, 2023

I've been investigating and rerunning the tests, it seems a fresh compilation provides better results. I still experience a small drop about 20K msg/s but I believe they are negligible compared against the benefits brought by the new locking strategy.

@Mallets Mallets merged commit 213bd36 into master Apr 4, 2023
@Mallets Mallets deleted the tables-locking branch April 4, 2023 11:10
p-avital pushed a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants