Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router reorg #587

Merged
merged 52 commits into from
Jan 31, 2024
Merged

Router reorg #587

merged 52 commits into from
Jan 31, 2024

Conversation

OlivierHecart
Copy link
Contributor

@OlivierHecart OlivierHecart commented Nov 14, 2023 •
edited
Loading

This PR brings:

  • Abstracted hats to avoid most of if not all tables.whatami checks.
  • Basic interceptors.
  • Preserved performances.

@OlivierHecart
Code move
66f41d8
@OlivierHecart
Code move
ec960ea
@OlivierHecart
Use RoutingContext type
939daa4
@OlivierHecart
Structs split
6e1c124
@OlivierHecart
Renaming
239d8cb
@OlivierHecart
Visibility
b0f999b
@OlivierHecart
Move ingress/egress filters out of pubsub
2a5466b
@OlivierHecart
Make hat abstract
0f2fa24
@OlivierHecart
Abstract missing close_face fn
002db77
@OlivierHecart
Duplicate hat
a33fcf1
@OlivierHecart
Move Primitives
6b61780
@OlivierHecart
Move link_id into HatFace
0a76ae3
@OlivierHecart
Change face initialization
ef541d8
@OlivierHecart
Interceptors
1755ba9
@OlivierHecart
Interceptor types renaming
cb693dc
@OlivierHecart
Rename RoutingContext
c520168
@OlivierHecart
Add RoutingContext and LoggerInterceptor
a4a672e
@OlivierHecart
Interceptors can access the Config at construction
59e8de7
@OlivierHecart
Split linkstate and p2p peer hats
9c94df5
@OlivierHecart
Simplify HatTrait init function
0096e59
@OlivierHecart
Hats cleanup
d4fac3d
@OlivierHecart
Reintroduce routes precomputation
7c8732c
@OlivierHecart
Improve routes precomputation
b2a7ee2
@OlivierHecart
Reintroduce matching pulls precomputation
43fcb78
@OlivierHecart
Perf improvements
7cd513a
@OlivierHecart
Perf improvements
b530da2
@OlivierHecart
Merge branch 'master' into router-reorg
05e9c3b
@OlivierHecart
Remove files wrongly reintroduced by merge
d5fcdfa
@OlivierHecart
Fix complete_n build
331cb3f
@OlivierHecart
Remove useless checks
458e64c
@Mallets
Copy link
Member

Mallets commented Jan 31, 2024

I've run z_sub_thr and z_pub_thr on this PR and against main. Below the results showing no major regressions nor gain depending on the payload size.

image

Target paltform:

  • Ubuntu 22.04 x86-64
  • AMD Ryzen 7 5800X

@Mallets Mallets merged commit 5601669 into main Jan 31, 2024
15 checks passed
@Mallets Mallets deleted the router-reorg branch January 31, 2024 16:40
@Mallets Mallets restored the router-reorg branch January 31, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@p-avital p-avital Awaiting requested review from p-avital

Assignees

@OlivierHecart OlivierHecart

Labels
enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierHecart @fuzzypixelz @Mallets