Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build plugins with default zenoh features #745

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Feb 21, 2024

fixes the issue:

cargo build --bin zenohd
cargo build -p zenoh-plugin-rest
cd target/debug
./zenohd

fails with rest plugin version incompatibility because zenohd is compiled with feature "zenoh/default", but pluigns are not

@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets
Copy link
Member

Mallets commented Mar 13, 2024

@milyin what's the status of this PR?

@milyin
Copy link
Contributor Author

milyin commented Mar 13, 2024

I didn't merged it on time due to check failures unrelated to fix itself.
Verified it again, fix is still actual. Merging

@milyin milyin merged commit 63965fc into main Mar 13, 2024
14 checks passed
@milyin milyin deleted the default_features_fix branch March 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants