Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RingBuffer to get the latest sample. #851

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Support RingBuffer to get the latest sample. #851

merged 10 commits into from
Mar 26, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Mar 20, 2024 •
edited
Loading

As a successor of #782, create a RingBuffer for users to get the latest data easily.

Closes #809

@evshary
Add RingQueue to support getting the latest sample.
76d71c9 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@eclipse-zenoh-bot
Copy link
Contributor

@evshary If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@evshary If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets mentioned this pull request Mar 20, 2024
Merged
@evshary
Rename RingQueue to RingBuffer.
6298f31 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
Update examples.
5066ae6 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary evshary changed the title Add RingQueue to support getting the latest sample. Support RingBuffer to get the latest sample. Mar 22, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@evshary If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@evshary If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@evshary
Add document.
3a81194 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
Add test for RingBuffer.
f000c59 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary evshary marked this pull request as ready for review March 22, 2024 09:32
Mallets
Mallets reviewed Mar 25, 2024
View reviewed changes
zenoh/src/handlers.rs Outdated Show resolved Hide resolved
Mallets
Mallets reviewed Mar 25, 2024
View reviewed changes
zenoh/src/handlers.rs Outdated Show resolved Hide resolved
@evshary
Use the correct naming convention (CameCase)
1fdcbb3 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
Add file header.
d53fe36 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
gename z_pull and update the usage.
507c678 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
Use ring instead of cache.
896e20a 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@evshary
Add sleep to wait for the result in pubsub_with_ringbuffer.
b772abb 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@Mallets Mallets merged commit c7cc575 into eclipse-zenoh:protocol_changes Mar 26, 2024
8 checks passed
@Mallets Mallets mentioned this pull request Mar 26, 2024
Closed
@evshary evshary deleted the add_ring_queue branch March 26, 2024 12:36
@evshary evshary mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evshary @eclipse-zenoh-bot @Mallets