Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code launcher should update the projects in vscode-workspace at restart #22630

Closed
l0rd opened this issue Oct 25, 2023 · 2 comments
Closed

VS Code launcher should update the projects in vscode-workspace at restart #22630

l0rd opened this issue Oct 25, 2023 · 2 comments
Assignees
@vitaliy-guliy
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Oct 25, 2023 •
edited
Loading

Is your enhancement related to a problem? Please describe

Currently VS Code launcher is adding projects from the devfile only when the .vscode-workspace file doesn't exist. So it does that only at startup.

The problem is that if a user starts a workspace, adds a new project (or dependent project) in the devfile.yaml and select "restart from local devfile", the new project won't be added to the .vscode-workspace file and the user won't see it (although it has been cloned in /projects).

Describe the solution you'd like

Launcher should update an existing vscode-workspace file if:

  • it was created automatically by the launcher
  • the projects have changed
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/editor/vscode Issues related to the Code OSS editor of Che labels Oct 25, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 25, 2023
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 25, 2023
@SDawley
Copy link
Contributor

SDawley commented Oct 30, 2023

Decided to include in 3.11 release/next sprint.

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Nov 3, 2023
@vitaliy-guliy vitaliy-guliy self-assigned this Nov 8, 2023
@vitaliy-guliy vitaliy-guliy mentioned this issue Nov 16, 2023
Merged
@l0rd
Copy link
Contributor Author

l0rd commented Dec 14, 2023

@vitaliy-guliy can you confirm that if a user starts a new workspace from a git repository with a .vscode/settings.json then the VS Code settings in that file will be applied to the VS Code workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliy-guliy vitaliy-guliy

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@l0rd @vitaliy-guliy @che-bot @SDawley