Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The context menu for Git in Project Explorer is invalid #3271

Closed
monaka opened this issue Dec 5, 2016 · 1 comment
Closed

The context menu for Git in Project Explorer is invalid #3271

monaka opened this issue Dec 5, 2016 · 1 comment
Assignees
@vinokurig
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
5.1.0

Comments

@monaka
Copy link
Member

monaka commented Dec 5, 2016

Same as title of this issue.

Reproduction Steps:

  1. Click any content in ProjectExplorer
  2. Right click and show Git sub-menu.
  3. Look

Expected behavior:

Shown Git menu same as the menu bar.

screenshot 2016-12-05 at 14 21 57 - display 2

Observed behavior:

Listed Compare sub-sub-menu only.

screenshot 2016-12-05 at 14 20 55 - display 2

Che version: 5.0.0-M7
OS and version: Independent
Docker version: Independent
Che install: Independent

Additional information:

I've already see where should be fixed. I'll send PR in a couple of days.

  • Problem started happening recently, didn't happen in an older version of Che: Unknown
  • Problem can be reliably reproduced, doesn't happen randomly: Yes
@monaka
Copy link
Member Author

monaka commented Dec 5, 2016

Referring to SubversionExtension.java, there should not be same columns between the menu bar and the context menu. But it should be provided some actions like gitAddToIndex by the context menu.

@vkuznyetsov vkuznyetsov added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/enterprise sprint/next labels Dec 5, 2016
@vinokurig vinokurig self-assigned this Dec 27, 2016
@vinokurig vinokurig added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 28, 2016
@vinokurig vinokurig mentioned this issue Jan 5, 2017
Merged
@vinokurig vinokurig added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 5, 2017
@vinokurig vinokurig added this to the 5.1.0 milestone Jan 10, 2017
@JamesDrummond JamesDrummond mentioned this issue Jan 31, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
3 participants
@monaka @vkuznyetsov @vinokurig