Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonah/remove accidentally committed files multiple #74

Conversation

jonahgraham
Copy link
Contributor

@jayjaybillings I believe these are all accidentally committed files, reasons for each part of their respective commits.

Added in 8b6cd04

org.eclipse.january.geometry.model.ui/
  These files exist in a directory/project that has no corresponding
  source files.
org.eclipse.january.geometry.model.ide/bin/
  These are compiled class files that seem to be missing from
  a .gitignore.
org.eclipse.january.geometry.model.ide/.gitignore
  Add the missing .gitignore for the above

Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
These files are all listed in .gitignore, but were not removed from
source control when the .gitignore was updated.

Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
@jonahgraham
Copy link
Contributor Author

This addresses Issue #73

@jayjaybillings
Copy link
Member

All checks pass. Since the number of lines changes is all deletions (minus one addition), we can accept this without requiring a CQ. Thank you very much for your contribution!

@jayjaybillings jayjaybillings merged commit 6af5af1 into eclipse:jay/model Jul 7, 2016
@jonahgraham jonahgraham deleted the jonah/remove_accidentally_committed_files_multiple branch July 7, 2016 14:29
@jonahgraham
Copy link
Contributor Author

Thanks @jayjaybillings Off to do the Initial contribution and CQ now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants