Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move collectPrimitive code to InternalArrayIterate from FastList and ArrayIterate #1350

Closed
donraab opened this issue May 15, 2022 · 2 comments
Closed

Move collectPrimitive code to InternalArrayIterate from FastList and ArrayIterate #1350

donraab opened this issue May 15, 2022 · 2 comments
Assignees
@Desislav-Petrov
Labels
enhancement help wanted tech-debt

Comments

@donraab
Copy link
Contributor

donraab commented May 15, 2022 •
edited
Loading

FastList and ArrayIterate should have their implementations replaced with delegation to InternalArrayIterate for the following primitive collect methods.

collectBoolean
collectByte
collectChar
collectDouble
collectInt
collectFloat
collectLong
collectShort
@Desislav-Petrov
Copy link
Contributor

I can look at that

@donraab
Copy link
Contributor Author

donraab commented May 19, 2022

Hi @Desislav-Petrov, thanks for volunteering. I have assigned this issue to you.

Desislav-Petrov added a commit to Desislav-Petrov/eclipse-collections that referenced this issue Jun 14, 2022
@Desislav-Petrov
Refactor to use internal array iterate - closes eclipse-collections#1350
9f8826a
Desislav-Petrov added a commit to Desislav-Petrov/eclipse-collections that referenced this issue Jun 16, 2022
@Desislav-Petrov
Refactor to use internal array iterate - closes eclipse-collections#1350
c13f905
Desislav-Petrov added a commit to Desislav-Petrov/eclipse-collections that referenced this issue Jul 18, 2022
@Desislav-Petrov
Refactor to use internal array iterate - closes eclipse-collections#1350
20d5f80
Desislav-Petrov added a commit to Desislav-Petrov/eclipse-collections that referenced this issue Jul 20, 2022
@Desislav-Petrov
Refactor to use internal array iterate - closes eclipse-collections#1350
0fda671
donraab added a commit that referenced this issue Jul 30, 2022
@donraab
Merge pull request #1363 from Desislav-Petrov/refactor
7195830 
Refactor to use internal array iterate - closes #1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Desislav-Petrov Desislav-Petrov

Labels
enhancement help wanted tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donraab @Desislav-Petrov