implement subList() on primitive immutable lists #1160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement subList() on primitive immutable lists part of #1053 AbstractImmutableList defines subList() as returning an object of an inner class but here it is implemented as returning an object of the class itself
mohrezaei
requested changes
Nov 23, 2021
| { | ||
| throw new UnsupportedOperationException("subList not yet implemented!"); | ||
| return new ImmutableBooleanArrayList(this.BitSet.get(fromIndex, toIndex), toIndex - fromIndex) |
There was a problem hiding this comment.
copying the bitset is too expensive. Use a subclass instead.
| { | ||
| throw new UnsupportedOperationException("subList not yet implemented!"); | ||
| return new LongInterval(fromIndex, toIndex, this.step); |
There was a problem hiding this comment.
this looks wrong. The fromIndex/toIndex of the list is not the same as the from/to of the interval.
|
Sorry, when I asked for not using a subclass, I only meant
|
|
Closing this as two PRs with the same name could be a single PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement subList() on primitive immutable lists
part of #1053
AbstractImmutableList defines subList() as returning an object of an inner class
but here it is implemented as returning an object of the class itself