Implement swap() method on mutable primitive lists #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donraab
reviewed
Jun 10, 2020
...ctions-code-generator/src/main/resources/test/list/mutable/unmodifiablePrimitiveListTest.stg
Show resolved
Hide resolved
donraab
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Hi @vmzakharov, thanks for the contribution. I think there is a missing file for unmodifiable primitive collections throwing UnsupportedOperationException for swap. Please confirm.
donraab
approved these changes
Jun 10, 2020
|
@vmzakharov please rebase your PR and @nikhilnanivadekar can merge. |
Signed-off-by: vmzakharov <zakharov.vladimir.m@gmail.com>
nikhilnanivadekar
approved these changes
Jun 11, 2020
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
swap(index1, index2)method for swapping two list elements. Add corresponding tests on mutable primitive list tests and default implementations on the respective primitive list interfaces.Signed-off-by: vmzakharov zakharov.vladimir.m@gmail.com