Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more trace to understand the project import success rate #2726

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

testforstephen
Copy link
Contributor

Add more trace to understand the language server status:

  • Measure the import success rate. The indicator we can use is the error diagnostics. If the project root level has error or the Java file has unresolved import errors, we can count it as an import failure.
  • Detect the cases of jdk mismatch.

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. I noticed some odd behaviour with regard to the jdk mismatch, but it's related to the JVM auto-detection ( #2731 ) that comes from upstream.

I'll file a separate bug to discuss it.

@rgrunber rgrunber merged commit bdfbc34 into eclipse-jdtls:master Jun 28, 2023
@rgrunber
Copy link
Contributor

😐 forgot to squash. My mistake.

@testforstephen testforstephen deleted the jinbo_importStatus branch June 29, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants