-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more trace to understand the project import success rate #2726
Merged
rgrunber
merged 4 commits into
eclipse-jdtls:master
from
testforstephen:jinbo_importStatus
Jun 28, 2023
Merged
Add more trace to understand the project import success rate #2726
rgrunber
merged 4 commits into
eclipse-jdtls:master
from
testforstephen:jinbo_importStatus
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Fixed
Show fixed
Hide fixed
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Fixed
Show fixed
Hide fixed
jdneo
reviewed
Jun 27, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Outdated
Show resolved
Hide resolved
rgrunber
reviewed
Jun 27, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Show resolved
Hide resolved
rgrunber
reviewed
Jun 27, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Show resolved
Hide resolved
rgrunber
reviewed
Jun 27, 2023
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/TelemetryManager.java
Outdated
Show resolved
Hide resolved
testforstephen
force-pushed
the
jinbo_importStatus
branch
from
June 28, 2023 02:54
ca697e7
to
5168f41
Compare
rgrunber
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. I noticed some odd behaviour with regard to the jdk mismatch, but it's related to the JVM auto-detection ( #2731 ) that comes from upstream.
I'll file a separate bug to discuss it.
😐 forgot to squash. My mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more trace to understand the language server status: