Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename topdownpacking.nodePlacement #947

Closed
soerendomroes opened this issue Jul 31, 2023 · 0 comments · Fixed by #951
Closed

Rename topdownpacking.nodePlacement #947

soerendomroes opened this issue Jul 31, 2023 · 0 comments · Fixed by #951
Milestone

Comments

@soerendomroes
Copy link
Contributor

The option topdownpacking.nodePlacement.strategy collides with the already existing layered.nodePlacement.strategy.
Since nodePlacement.strategy is a commonly used in example models, these break since we need to specify that the layered node placement strategy is meant.

I suggest renaming the topdownpacking.nodePlacement.strategy to something else (which is not placement or noedPlacement since both are already in use by rectpacking and layered.

@Eddykasp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant