This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Support Java overloaded instance methods #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 31, 2015 16:00
Introduced for overloaded methods detection.
| return Extractors.isPublic(m) && | ||
| Extractors.isConcrete(m) && | ||
| m.getName().equals(invocation.name()) && | ||
| (m.getParameterCount() + 1 == invocation.arity()) || (m.isVarArgs() && (m.getParameterCount() <= invocation.arity())); |
There was a problem hiding this comment.
looks like déjà vu... maybe TypeMatching.argumentsNumberMatches ?
|
@yloiseau This makes me think that This PR focuses only on instance methods, but once refactored a bit we could improve |
jponge
changed the title
|
Recorded #341 for overloaded static methods. I'm ok with this PR, if you agree then I'll go ahead and merge. |
|
👍 |
jponge
added a commit
that referenced
this pull request
Jan 6, 2016
Support Java overloaded instance methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports resolving and invalidating Java overloaded instance methods.