Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add worker image pull secret name #273

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

wcp1231
Copy link
Contributor

@wcp1231 wcp1231 commented Mar 25, 2024

Hi, all

Could I have a review for this patch. I would be very grateful.

The official image is out of date, so I built an image and pushed it to our private registry, then found that it needs set pull secret to pull the elastic worker image from the private registry.

This patch adds the image-pull-secret-name option to the master node so that it can pull image from the private registry when scheduling a worker pod.

Thanks

Copy link
Contributor

@D-D-H D-D-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D-D-H
Copy link
Contributor

D-D-H commented Mar 25, 2024

Please sign the eca.

Thanks!

@wcp1231 wcp1231 force-pushed the add-elastic-worker-image-pull-secret branch from b3dd32b to 30d0d68 Compare March 25, 2024 13:29
@wcp1231
Copy link
Contributor Author

wcp1231 commented Mar 25, 2024

The change looks good to me.

Please update the doc located at:

Okay, I've updated the doc and sign the eca.

@D-D-H D-D-H merged commit 93a3a98 into eclipse:main Mar 26, 2024
2 checks passed
@D-D-H
Copy link
Contributor

D-D-H commented Mar 26, 2024

Thanks for the contribution.

I updated the commit title ('feature' -> 'feat') to keep consistent.

@wcp1231 wcp1231 deleted the add-elastic-worker-image-pull-secret branch March 26, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants