feature: add worker image pull secret name #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, all
Could I have a review for this patch. I would be very grateful.
The official image is out of date, so I built an image and pushed it to our private registry, then found that it needs set pull secret to pull the elastic worker image from the private registry.
This patch adds the
image-pull-secret-name
option to the master node so that it can pull image from the private registry when scheduling a worker pod.Thanks