Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[databroker] Update and move TLS & authorization warnings. #647

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[databroker] Update and move TLS & authorization warnings. #647

merged 1 commit into from
Sep 6, 2023

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Sep 4, 2023 •
edited
Loading

Whether to warn if TLS and/or authorization is enabled should be determined by user intentions.

  • Only warn about authorization not being enabled if --disable-authorization has not been provided.
  • Only warn about TLS not being enabled if --insecure has not been provided.

@argerus argerus force-pushed the feature/refactor_authorization branch from efffb91 to e4fdad2 Compare September 5, 2023 06:23
@argerus argerus force-pushed the feature/refactor_authorization branch from e4fdad2 to cb3b5d1 Compare September 5, 2023 11:26
@argerus argerus changed the title [databroker] Refactor authorization [databroker] Move call site of TLS & authorization warnings. Sep 6, 2023
@argerus argerus changed the title [databroker] Move call site of TLS & authorization warnings. [databroker] Update and move TLS & authorization warnings. Sep 6, 2023
@argerus argerus merged commit 7190bc8 into eclipse:master Sep 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikbosch erikbosch erikbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argerus @erikbosch