Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline view should provide more visual separation displaying symbols gathered from properties files #615

Closed
scottkurz opened this issue Apr 20, 2023 · 3 comments · Fixed by #640

Comments

@scottkurz
Copy link

PROBLEM

Using Eclipse 4.27 with Quarkus Tools (using LSP4MP 0.6) I see this for application.properties in the Outline view

image

Note how the key and value are collapsed together without a space.

On the other hand, looking at a Java file in Eclipse, we see <element name> : <type> with the space and colon.

image

SUGGESTION

I think simply adding a space, combined with the different font, would be enough of a separation (we don't need the ':' IMHO).

OTHER INFO

Note the comment showing the JSON-RPC payload returned by LSP4MP in a case similar to my screenshot. (I first opened the issue against LSP4MP before getting directed here).

@mickaelistria
Copy link
Contributor

I confirm what @angelozerr says in the other issue, it's definitely a client-side issue, more specifically in SymbolsLabelProvider . Would you be interested in submitting a PR that adds the necessary space?

@scottkurz
Copy link
Author

I confirm what @angelozerr says in the other issue, it's definitely a client-side issue, more specifically in SymbolsLabelProvider . Would you be interested in submitting a PR that adds the necessary space?

Yes, I'd be interested. Not sure exactly when I'll get to it but thanks for the starting point suggestion.

@ghentschke
Copy link
Contributor

I stumbled across the same issue. I can provide a PR as well.

ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue May 15, 2023
ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue May 15, 2023
ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants