Fix NPE when the server is stopped due to a failure during initialization #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickaelistria , thanks, you suggestion is better. I did a mistake with the PR, so we lost the previous PR, I created a new one. |
| @@ -243,7 +243,8 @@ public synchronized void start() throws IOException { | |||
| stop(); | |||
| } | |||
| return null; | |||
| }).thenApply(unused -> { | |||
| }); | |||
| initializeFuture.thenCombineAsync(initializeFuture, (unused1, unused2) -> { | |||
There was a problem hiding this comment.
I don't think that future.thenCombineAsync(future, ...) is a good nor expected pattern.
I've a bit lost track about what you're willing to achieve. Maybe combining is not the right idea after all.
Maybe what you'd like to add here is just a line initializeFuture.exceptionallyAsync(this::stop) here before adding the other futures (which shouldn't be invoked anyway when previous future has exception)
|
I think I got it right now :) Would you agree? |
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.