Match diagnostics with empty ranges #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
reviewed
Mar 28, 2023
| @@ -207,7 +207,7 @@ private IMarker getExistingMarkerFor(IDocument document, Diagnostic diagnostic, | |||
| for (IMarker marker : remainingMarkers) { | |||
| try { | |||
| if (LSPEclipseUtils.toOffset(diagnostic.getRange().getStart(), document) == MarkerUtilities.getCharStart(marker) | |||
| && LSPEclipseUtils.toOffset(diagnostic.getRange().getEnd(), document) == MarkerUtilities.getCharEnd(marker) | |||
| && (LSPEclipseUtils.toOffset(diagnostic.getRange().getEnd(), document) == MarkerUtilities.getCharEnd(marker) || Objects.equals(diagnostic.getRange().getStart(), diagnostic.getRange().getEnd())) | |||
There was a problem hiding this comment.
Since when we create the marker, we already set the end position to be one char forward, would the existing condition not match already? Why do we need a new one?
There was a problem hiding this comment.
Since when we create the marker, we already set the end position to be one char forward
Only in case of empty range
would the existing condition not match already?
No, it does not match this case.
|
The test failure is actually caused by the MockLanguageServer being incorrect in some aspects and sending diagnostics from the wrong server. I'm working on improving this in a dedicated commit. |
mickaelistria
force-pushed
the
diagnostics-empty-range
branch
from
4d70d8a
to
1c57199
Compare
In Eclipse, we set a minimal range of 1 character, even for diagnostics that have an empty range (just a position); so this fixes ensure such markers and diagnostics are still matched together upon update, to avoid re-creating diagnostics.
mickaelistria
force-pushed
the
diagnostics-empty-range
branch
from
1c57199
to
e6884b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Eclipse, we set a minimal range of 1 character, even for diagnostics that have an empty range (just a position); so this fixes ensure such markers and diagnostics are still matched together upon update, to avoid re-creating diagnostics.