Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against LSP4J 0.22.0 #919

Merged
merged 1 commit into from Feb 14, 2024
Merged

Build against LSP4J 0.22.0 #919

merged 1 commit into from Feb 14, 2024

Conversation

akurtakov
Copy link
Contributor

No description provided.

@rubenporras
Copy link
Contributor

@mickaelistria , shall we have a last 2.24.x release before upgrading LSP4J? I would be for doing it

@akurtakov
Copy link
Contributor Author

Looking at 0.24.7...master doesn't strike me as anything major in the last 2 weeks to deserve a release. Am I missing smth?

@rubenporras
Copy link
Contributor

You are right, there is nothing in the last two weeks which is a major. The reason I propose to do a minor release before the LSP4J upgrade, is that consumers can get the latest fixes without upgrading LSP4J.

@akurtakov
Copy link
Contributor Author

So if you want to do a release do one and please merge this one. We will need a release right after that so we deliver latest lsp4j/lsp4e combo to simrel.

@rubenporras
Copy link
Contributor

Okay, I will do one shortly and will merge this one then.

@rubenporras
Copy link
Contributor

@akurtakov
(org.eclipse.lsp4e/0.18.4.202402140838). Expected to have bigger x.y.z than what is available in baseline (0.18.4.202402140832)
could you bump the number?

@akurtakov akurtakov merged commit e0a7d46 into eclipse:master Feb 14, 2024
2 checks passed
@akurtakov akurtakov self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants