Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug #130: Support for JSON-RPC-like Debug Server Protocol's RPC #131
This provides the supporting RPC implementation for VSCode's Debug Protocol
See the class comment on DebugMessageTypeAdapterFactory for details on
Signed-off-by: Jonah Graham firstname.lastname@example.org
Thank you for this proposal! The code seems to me of very high quality. I would support your nomination as a committer :-)
Are you planning to also implement service interfaces with corresponding data structures in the style of
org.eclipse.lsp4j.services.LanguageServer? Or have you already done that?
I am planning to create a PR in the coming days with the equivalent for the debug protocol. It is generated from the debug protocol json schema. Originally I was going to put it in a plug-in called org.eclipse.dsp4j, but based on your other comments, perhaps org.eclipse.lsp4j.debug would make more sense.
referenced this pull request
Nov 23, 2017
@spoenemann I have updated the code with all your feedback and it is again ready for review.
This update has the next part too, the service protocol files. As the DSP has a Json Schema that defines it, the
As long as the main source for the DSP is a JSON schema, it totally makes sense to generate the Java code from it. Ideally, the generator would be in this project (
org.eclipse.lsp4j.generator), but probably we cannot just copy the code from Microsoft/vscode-debugadapter-node or a derived version of it. We can leave that problem for later and first make this PR ready for merge.
@spoenemann Its ready, I have hopefully addressed all your concerns adequately. With the generation of
Looks good to me, thanks again!
A further improvement would be to generate
@NonNull annotations from the
required properties in the schema, but I'll create a separate issue for that.