Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jakarta Servlet @WebFilter diagnostic #13

Closed
kathrynkodama opened this issue Sep 29, 2020 · 0 comments · Fixed by #32 or #44
Closed

Jakarta Servlet @WebFilter diagnostic #13

kathrynkodama opened this issue Sep 29, 2020 · 0 comments · Fixed by #32 or #44
Assignees
@rezaakv
Labels
diagnostic Diagnostic item

Comments

@kathrynkodama
Copy link
Contributor

kathrynkodama commented Sep 29, 2020 •
edited
Loading

Classes annotated with @WebFilter must implement the Filter interface.

https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/annotation/WebFilter.html
https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/Filter.html

See:
https://eclipse-ee4j.github.io/jakartaee-tutorial/servlets006.html
*note the tutorial is referring to Jakarta EE 8, with Jakarta EE 9 the package names will change to jakarta... which is why they are slightly different in the apidocs.
@kathrynkodama kathrynkodama added the diagnostic Diagnostic item label Sep 29, 2020
@kathrynkodama kathrynkodama changed the title Jakarta Servlet 4.0 @WebFilter diagnostic Jakarta Servlet @WebFilter diagnostic Oct 1, 2020
@kathrynkodama kathrynkodama mentioned this issue Oct 8, 2020
Open
83 tasks
@rezaakv rezaakv self-assigned this Oct 13, 2020
@rezaakv rezaakv linked a pull request Oct 29, 2020 that will close this issue
Added @WebFilter and @WebListener annotation diagnostics #32
Merged
@rezaakv rezaakv linked a pull request Nov 6, 2020 that will close this issue
Added member value check diagnostics for WebServlet and WebFilter #44
Merged
@kathrynkodama kathrynkodama mentioned this issue Nov 28, 2020
Closed
@kathrynkodama kathrynkodama mentioned this issue Sep 20, 2021
Open
tiganov added a commit to tiganov/lsp4jakarta that referenced this issue Sep 21, 2021
@tiganov
Lower WebServlet (eclipse#159) and WebFilter (eclipse#13) diagnostics…
d159452 
… to warning severity

We do not have enough type hierarchy information to definitely say that the user is not extended/implementing the correct class/interface.
tiganov added a commit to tiganov/lsp4jakarta that referenced this issue Sep 30, 2021
@tiganov
Lower WebServlet (eclipse#159) and WebFilter (eclipse#13) diagnostics…
322edfd 
… to warning severity

We do not have enough type hierarchy information to definitely say that the user is not extended/implementing the correct class/interface.
kathrynkodama added a commit that referenced this issue Oct 4, 2021
@kathrynkodama
Merge pull request #172 from tiganov/issue_159
f61da21 
Lower WebServlet (#159) and WebFilter (#13) diagnostics to warning severity
kathrynkodama added a commit to kathrynkodama/lsp4jakarta that referenced this issue Nov 8, 2022
@kathrynkodama
updated documentation (eclipse#13)
3130814 
* updated documentation

Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
mezarin added a commit to mezarin/lsp4jakarta that referenced this issue Oct 10, 2023
@mezarin
Merge pull request eclipse#13 from mezarin/vscode-config-updates
309979b 
updates to allow vscode to connect to jakarta ls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezaakv rezaakv

Labels
diagnostic Diagnostic item
Projects
None yet
Milestone
No milestone
2 participants
@kathrynkodama @rezaakv