Path params quickfix #278
Merged
Path params quickfix #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/main/java/org/eclipse/lsp4jakarta/jdt/core/websocket/WebSocketDiagnosticsCollector.java
Outdated
Show resolved
Hide resolved
...karta.jdt.test/src/main/java/org/eclipse/lsp4jakarta/jdt/websocket/JakartaWebSocketTest.java
Outdated
Show resolved
Hide resolved
giancarlopernudisegura
approved these changes
Apr 6, 2022
....jdt.core/src/main/java/org/eclipse/lsp4jakarta/jdt/core/websocket/AddPathParamQuickFix.java
Outdated
Show resolved
Hide resolved
Open
4 tasks
| @@ -31,20 +33,21 @@ | |||
| import org.eclipse.lsp4jakarta.jdt.codeAction.proposal.ModifyAnnotationProposal; | |||
|
|
|||
| /** | |||
| * Quickfix for adding missing attributes to annotations | |||
| * Quickfix for adding missing attributes to new or existing annotations | |||
There was a problem hiding this comment.
Can we clarify a bit further?
"Quickfix for adding new annotations or adding attributes to existing annotations"
Comment on lines
124
to
130
| protected String getLabel(String annotation, String... attributes) { | ||
| String type = ""; | ||
|
|
||
| String name = "Add " + attributes[0] + " to " + annotation; | ||
| name = name.concat(type); | ||
| return name; | ||
| } |
There was a problem hiding this comment.
Ideally I think we should handle the two label cases in this class (adding an annotation & adding an attribution to an annotation).
What do you think about this label being "Insert @Annotation" and then we create a new class "InsertAnnotationAttributesQuickFix" which extends "InsertAnnotationQuickFix" and overrides the label to the above? Then we don't have to include the label specific logic in "AddPathParamsQuickFix" and it can easily be reused.
There was a problem hiding this comment.
Sounds like a good idea! will implement that!
kathrynkodama
approved these changes
Apr 14, 2022
turkeylurkey
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #276