Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures #370

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

datho7561
Copy link
Contributor

Use FORCE flag when creating folders in the integration tests for microprofile.jdt.

Fixes #369

Signed-off-by: David Thompson davthomp@redhat.com

Use `FORCE` flag when creating folders in the integration tests for
`microprofile.jdt`.

Fixes eclipse#369

Signed-off-by: David Thompson <davthomp@redhat.com>
Copy link
Contributor

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fixes the errors as expected, thank you!

@datho7561 datho7561 merged commit eee7082 into eclipse:master Mar 7, 2023
@datho7561 datho7561 deleted the 369-fix-test-failures branch March 7, 2023 21:09
@rgrunber
Copy link
Contributor

rgrunber commented Mar 7, 2023

Makes sense. If the folders already exist there's going to be issues, which is always a risk when generating so many of these test cases. Was the method call throwing an exception ?

@datho7561
Copy link
Contributor Author

Yes, it was throwing an Exception, so the tests would error out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests error in BasePropertiesManagerTest#createParentFolders when running locally
3 participants