-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OASFactory.INSTANCE ignores the resolver set #80
Comments
The OASFactory follows the same static resolver pattern as of ConfigProvider from MP Config. We also posted in the google forum about the static resolver pattern and were told that it's fine/reasonable to expect that there is only one implementation of resolver within a vendor's environment and it be set at the beginning (vendor's responsibility). @Emily-Jiang your thoughts about the static resolver? We decided the OASFactory to be static so it's easy for end users to invoke the static createObject method. e.g. |
Solved by merge #85 |
Bumps jandex from 2.1.0.Final to 2.1.1.Final. Signed-off-by: dependabot[bot] <support@dependabot.com>
If you set the resolver via
OASFactoryResolver.setInstance
, that resolver is not used by invocations to the factory. The value is set when the class is loaded.Instead, you should just ask for the resolved instance on each invocation. I also wonder if this class should be an API, with methods defined, instead of being a static factory? Maybe a different issue.
The text was updated successfully, but these errors were encountered: