Issues #5 and #107: Clarify integration with CDI and FT #140
Conversation
| [[integration]] | ||
| == Integration with other MicroProfile technologies | ||
|
|
||
| The MicroProfile Rest Client can be used as a standalone technology. That means that an implementation could work without CDI, MicroProfile Config, etc. |
There was a problem hiding this comment.
Doesn't "The MP RC can be used as a standalone tech..." sound a bit like the implementations should work without Config and CDI?
There was a problem hiding this comment.
Yes. I want to communicate that CDI and Config are not strictly necessary - as the user could use the RestClientBuilder to programmatically create the client instance, set the base URI/URL, register providers, etc.
| === Other MicroProfile Technologies | ||
|
|
||
| Client requests can be automatically traced when using MP OpenTracing. Likewise, requests can be measured using MP Metrics. | ||
| Configuration and usage of these technologies should be defined their respective specification documents. |
There was a problem hiding this comment.
Missing an "in" between defined and their?
There was a problem hiding this comment.
Good catch! Fixed.
Includes new "Integration" section in the spec document and new TCK test cases for CDI interceptor support. Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>
andymc12
force-pushed
the
5-107-integration
branch
from
efc9c64
to
d38ea6d
Compare
|
Thanks for the reviews Ken and Michal! |
| " http://java.sun.com/xml/ns/javaee" + | ||
| " http://java.sun.com/xml/ns/javaee/beans_1_0.xsd\">" + | ||
| " <interceptors>" + | ||
| " <class>org.eclipse.microprofile.rest.client.tck.interfaces.LoggableInterceptor</class>" + |
There was a problem hiding this comment.
This is CDI 1.0 style (i.e. very old) of enabling an interceptor. I'd prefer using @Priority annotation (see also the Interceptors spec, 5.1 Defining Interceptor Order) - the test would be simpler and easier to understand.
There was a problem hiding this comment.
@mkouba - I think that makes sense. Since this has already been merged, would you mind opening a new PR with your proposed changes?
Includes new "Integration" section in the spec document and new TCK test cases for CDI interceptor support.
This should resolve issues #5 and #107.
Signed-off-by: Andy McCright j.andrew.mccright@gmail.com