Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the deprecation of AbstractJavaLaunchConfigurationDelegate getClasspath(ILaunchConfiguration) #60

Open
cdietrich opened this issue Jan 11, 2019 · 12 comments
Assignees

Comments

@cdietrich
Copy link
Member

cdietrich commented Jan 11, 2019

JDT wants to deprecate org.eclipse.jdt.launching.AbstractJavaLaunchConfigurationDelegate.getClasspath(ILaunchConfiguration)

we should address this.

we also should investigate what of customization is still needed at all

(affects mwe and mwe2)

@cdietrich cdietrich changed the title Address the deprecation of AbstractJavaLaunchConfigurationDelegate.getClasspath(ILaunchConfiguration) Address the deprecation of AbstractJavaLaunchConfigurationDelegate getClasspath(ILaunchConfiguration) Jan 11, 2019
@cdietrich cdietrich added this to the Release 2.10.1 milestone Feb 13, 2019
@cdietrich
Copy link
Member Author

@szarnekow this is the mwe jdt deprecation issue

@cdietrich
Copy link
Member Author

@szarnekow
Copy link
Contributor

I'd resort to reflection: use getClasspathAndModulepath, if available, fallback to getClasspath otherwise. Assign the module path and the classpath from the two dimensional result array to the VM runner config. What do you think, @cdietrich ?

@cdietrich
Copy link
Member Author

cdietrich commented Nov 25, 2019

sounds feasible. the downside would be that we would no longer recognize if they change it again.
as there is no direct build against "latest platform"

@szarnekow
Copy link
Contributor

I prefer raising the lower bound for JDT and use getClasspathAndModulePath

@cdietrich
Copy link
Member Author

the problem is that we set the min mwe version in xtext.sdk
so that wont work with Xtext + MWE (latest) + Oxygen3a

@cdietrich
Copy link
Member Author

of course we could keep the old runtime dep and use a newer target platform.
and hope we dont do programming errors
as we do it for xtext-core and extras

@cdietrich
Copy link
Member Author

we had a closer look.
new method is already there in 3a although marked as @since 3.10 whereas Oxygen3a as 3.9.100

@cdietrich
Copy link
Member Author

=> we can use the new method only

@cdietrich
Copy link
Member Author

or

		// Bug 529435 :to move to getClasspathAndModulepath after java 8 is sunset
		VMRunnerConfiguration runConfig = new VMRunnerConfiguration(mainTypeName, getClasspath(configuration));

@cdietrich
Copy link
Member Author

we also should investigate what of customization is still needed at all

@cdietrich
Copy link
Member Author

moved to 2.11.3

@cdietrich cdietrich modified the milestones: Release 2.11.3, Release 2.11.4 Jul 31, 2020
@cdietrich cdietrich modified the milestones: Release 2.11.4, Release 2.12.0 Oct 18, 2020
@cdietrich cdietrich removed this from the Release 2.12.1 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants