Fix compile and test errors with OSX omrintrospect

[EricYangIBM]

• Change clock_gettime() to gettimeofday() as the former is unavailable in earlier versions of OSX
• Disable backtrace functions for AArch64 OSX as they haven't been fully implemented yet

Signed-off-by: Eric Yang eric.yang@ibm.com

[babsingh]

What is the intent of this change? nmap/nmap#180 and its references recommend not to use gettimeofday.

[EricYangIBM]

clock_gettime() is not available pre OSX 10.12. I will have to add other changes to this PR as #6267 will be reverted due to test failures on aarch64 eclipse-openj9/openj9#14892

[keithc-ca]

What is the intent of this change? nmap/nmap#180 and its references recommend not to use gettimeofday.

If we want to avoid clock_gettime(), https://github.com/eclipse/omr/blob/master/port/unix/omrtime.c#L94 will need to change as well. For now though, this change seems reasonable to me.

[EricYangIBM]

Ran aarch64_mac tests and failed tests now pass https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk11_j9_sanity.functional_aarch64_mac_Personal/7/tapResults/
Except for cmdLineTester_CryptoTest_0 which isn't related to my PRs

[EricYangIBM]

This is with eclipse-openj9/openj9#14201

[babsingh]

jenkins build osx

[knn-k]

The reason for the cmdLineTester_CryptoTest_0 failure on AArch64 macOS above is the OpenSSL build settings. You don't need to care about it.

[EricYangIBM]

eclipse-openj9/openj9#14201 fixes the aarch64_mac failures in eclipse-openj9/openj9#14892 (this PR only fixes a build error), however the openj9 PR cannot be merged since that would enable javacores for osx while the implementation isn't promoted (blocked right now). Would it make sense to split eclipse-openj9/openj9#14201 and merge its dmpsup.c and gphandle.c changes first?

[babsingh]

Would it make sense to split eclipse-openj9/openj9#14201 and merge its dmpsup.c and gphandle.c changes first?

yes. fyi @pshipton @0xdaryl.

[EricYangIBM]

Just ran https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/12638/ with the second commit on this PR and the tests pass as well. Would it be better to merge this PR instead?

[babsingh]

with the second commit on this PR and the tests pass as well

Does this mean that the dmpsup.c and gphandle.c changes in eclipse-openj9/openj9#14201 are no longer needed?

[EricYangIBM]

Yes. It seems like something in backtrace_sigprotect is causing the failures

[babsingh]

Would it be better to merge this PR instead?

Yes, it will be better to isolate all changes within OMR if changes to downstream projects can be avoided.

Instead of just disabling backtrace_sigprotect, will it be better to disable all omrosbacktrace_impl.c code in order to avoid unexpected problems on OSX aarch64 until support on this platform is fully implemented and tested?

uintptr_t
omrintrospect_backtrace_thread_raw(OMRPortLibrary *portLibrary, J9PlatformThread *threadInfo, J9Heap *heap, void *signalInfo)
{
#if defined(OMR_ARCH_X86)
   ... existing code ...
#elif defined(OMR_ARCH_AARCH64) /* defined(OMR_ARCH_X86) */
   return 0;
#else /* defined(OMR_ARCH_AARCH64) */
#error Unsupported processor
#endif /* defined(OMR_ARCH_X86) */
}

uintptr_t
omrintrospect_backtrace_symbols_raw(OMRPortLibrary *portLibrary, J9PlatformThread *threadInfo, J9Heap *heap)
{
#if defined(OMR_ARCH_X86)
   ... existing code ...
#elif defined(OMR_ARCH_AARCH64) /* defined(OMR_ARCH_X86) */
   return 0;
#else /* defined(OMR_ARCH_AARCH64) */
#error Unsupported processor
#endif /* defined(OMR_ARCH_X86) */
}

[babsingh]

• Don't squash the commits.
• Update the commit title/message of the second commit.
• Include the details of both commits in the PR's description.
• Revert Enable native thread collection in javacores on OSX eclipse-openj9/openj9#14201 to its previous state.
• Confirm that the new changes work with OpenJ9.

[babsingh]

jenkins build osx

[EricYangIBM]

https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/12658/
Existing aarch64mac failures are known issues

[babsingh]

lgtm. @keithc-ca @0xdaryl, for final review and merge.

[pshipton]

FYI OMR promotion to OpenJ9 was blocked by #6267, and should be unblocked by this PR.

[0xdaryl]

Looks fine to me. @keithc-ca : could you formally approve please?

[keithc-ca]

I would have preferred that the condition here matched the condition that enables use of these functions, that is defined(OMR_ARCH_X86) instead of !defined(OMR_ARCH_AARCH64), but given those are the only two architectures on which macOS is supported, the conditions are equivalent for all practical purposes.

[knn-k]

I am going to implement the backtrace feature for AArch64 macOS sometime later.
I would like this PR to be merged soon.

[keithc-ca]

My previous minor comment can be addressed later, certainly by adding support for aarch64.