Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable Code Cache disclaiming #7324

Merged
merged 1 commit into from
May 8, 2024

Conversation

gita-omr
Copy link
Contributor

No description provided.

@gita-omr gita-omr requested a review from dsouzai as a code owner April 26, 2024 04:35
gita-omr added a commit to gita-omr/openj9 that referenced this pull request Apr 26, 2024
- use the same heuristcs for code cache disclaim as for data cache
- disclaim starting from the cold code
- move stack overflow outline instructions into the warm area to
  increase disclaim efficiency

Depends on: eclipse-omr/omr#7300
Depends on: eclipse-omr/omr#7324
@0xdaryl
Copy link
Contributor

0xdaryl commented May 6, 2024

Should "cold" be in the option name if this is specific to cold code cache disclaiming? i.e., enableColdCodeCacheDisclaiming

@gita-omr
Copy link
Contributor Author

gita-omr commented May 6, 2024

Should "cold" be in the option name if this is specific to cold code cache disclaiming? i.e., enableColdCodeCacheDisclaiming

Good question. I deliberately made it more general in case we want to experiment and disclaim warm code as well.

@0xdaryl 0xdaryl self-assigned this May 8, 2024
@0xdaryl
Copy link
Contributor

0xdaryl commented May 8, 2024

I deliberately made it more general in case we want to experiment and disclaim warm code as well.

OK, but I'm worried we won't remember to update the option description in the future if and when that happens. If that's your plan, can you drop "cold" from the option description text then?

@gita-omr
Copy link
Contributor Author

gita-omr commented May 8, 2024

Removed "cold" from option description.

@0xdaryl
Copy link
Contributor

0xdaryl commented May 8, 2024

Only change since CI last ran was to the contents of a C string. Re-running CI is not necessary.

@0xdaryl 0xdaryl merged commit 9a431c4 into eclipse-omr:master May 8, 2024
4 of 6 checks passed
gita-omr added a commit to gita-omr/openj9 that referenced this pull request May 24, 2024
- use the same heuristcs for code cache disclaim as for data cache
- disclaim starting from the cold code
- move stack overflow outline instructions into the warm area to
  increase disclaim efficiency

Depends on: eclipse-omr/omr#7300
Depends on: eclipse-omr/omr#7324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants