added dependency="true" where missing #4585
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Please allow me to self-merge this very small fix - thanks! |
| @@ -177,7 +177,7 @@ | |||
| <feature name="esh-tp-serial" version="${project.version}"> | |||
| <capability>esh.tp;feature=serial;version=3.12.0</capability> | |||
|
|
|||
| <bundle>mvn:org.openhab/nrjavaserial/3.12.0.OH</bundle> | |||
| <bundle dependency="true">mvn:org.openhab/nrjavaserial/3.12.0.OH</bundle> | |||
There was a problem hiding this comment.
I don't think this is correct. If you mark this bundle as dependency="true" you have to add a special requirement.
The feature esh-tp-serial is already marked with dependency="true" and so installed if necessary only.
But if I install esh-tp-serial manually because I want the serial TP feature to be installed, also the bundle should be installed. So, if you don't want to be to strict about the bundle itself, you need to add at least the requirement for the specific package that should be available.
There was a problem hiding this comment.
Hm, I tried to align it with the rest and we e.g. have it the same way for esh-tp-apache-commons, esh-tp-httpclient and some others. But I have to admit that I didn't really yet get the meaning&effect of dependency=true on bundles. Are the dependent bundles only transitive dependencies that will be there anyhow? Or what makes the difference and how should it be used?
There was a problem hiding this comment.
The TP feature file is not as clean as it should be at the moment. So okay for me to keep it this way for the moment.
I will try to add a summary about that feature file itself, my initial intention and what I think we should do. Will ping you as soon as I will find a time slot.
This reverts commit 20e7813.
Signed-off-by: Kai Kreuzer kai@openhab.org