Show error on wrong token #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setExpectContinueEnabled is added to get rid of broken pipe exception.
The PUT/POST is sent with a huge payload with the header X-Vulas-Token. If the Token is invalid the server quickly closes the connection, the client still tries to send a payload even when the connection was closed at the server end which causes broken pipe exception. Expect Continue is introduced in HTTP 1.1 and handles this well as it just sends the headers and tries to validate if there is any failure, if there is no failure it sends the whole payload.
ExpectContinue is part of HTTP 1.1 spec
More details - https://hc.apache.org/httpclient-3.x/apidocs/org/apache/commons/httpclient/methods/ExpectContinueMethod.html