Fix for multi release log4j jar #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeetpatil
force-pushed
the
multi-rel-java
branch
from
2418127
to
6492be0
Compare
sumeetpatil
force-pushed
the
multi-rel-java
branch
from
6492be0
to
089aee6
Compare
henrikplate
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steady clients kb-importer, patch-analyzer, and others were failing with Java 9 (and later releases).
This is because log4j-api 2.9.1 and above are packaged as a multi-release JAR and support the use of the StackWalker and Process APIs. But the Steady clients do not support muti-release JAR due to which the clients fail with errors.
The changes in this PR will add muti-release JAR support for Steady clients (by adding the manifest file entry
Multi-Release: trueto self-contained Uber-JARs).