Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to facilitate setup and execution of Docker Compose app #502

Merged
merged 29 commits into from
Oct 18, 2021

Conversation

henrikplate
Copy link
Contributor

@henrikplate henrikplate commented Oct 1, 2021

This PR aims at facilitating the setup and execution of Steady's Docker Compose application with the two bash scripts setup-steady.sh and start-steady.sh.

Moreover, the file .steady.properties in the user's home directory can be used to store user-specific configuration settings.

In this context, the filename pattern of configuration files has been changed from vulas-*.properties to steady-*.properties. Still, configuration files adhering to the old pattern are still considered - as long as they exist in the file system (opposed to being part of JAR or WAR files).

TODOs

  • Tests
  • Documentation

@henrikplate henrikplate added the wip Work in progress - Don't merge label Oct 1, 2021
@henrikplate henrikplate changed the title Renamed kaybee conf file Added scripts to facilitate local setup and execution of Docker app Oct 11, 2021
@henrikplate henrikplate changed the title Added scripts to facilitate local setup and execution of Docker app Scripts to facilitate setup and execution of Docker Compose app Oct 11, 2021
docker/setup-steady.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@serenaponta serenaponta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments:

  • i would add a comment in "docker-compose-new.yml" to document its purpouse.
  • on top of explaining how to start the backend, i would also add a one line on how to stop it (though it should be obvious i would still add it)

Jenkinsfile Show resolved Hide resolved
@henrikplate henrikplate removed the wip Work in progress - Don't merge label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants