-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts to facilitate setup and execution of Docker Compose app #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpose environment
copernico
reviewed
Oct 8, 2021
henrikplate
changed the title
Renamed kaybee conf file
Added scripts to facilitate local setup and execution of Docker app
Oct 11, 2021
henrikplate
changed the title
Added scripts to facilitate local setup and execution of Docker app
Scripts to facilitate setup and execution of Docker Compose app
Oct 11, 2021
serenaponta
reviewed
Oct 14, 2021
serenaponta
reviewed
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few minor comments:
- i would add a comment in "docker-compose-new.yml" to document its purpouse.
- on top of explaining how to start the backend, i would also add a one line on how to stop it (though it should be obvious i would still add it)
shared/src/main/java/org/eclipse/steady/shared/util/VulasConfiguration.java
Show resolved
Hide resolved
serenaponta
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at facilitating the setup and execution of Steady's Docker Compose application with the two bash scripts
setup-steady.sh
andstart-steady.sh
.Moreover, the file
.steady.properties
in the user's home directory can be used to store user-specific configuration settings.In this context, the filename pattern of configuration files has been changed from
vulas-*.properties
tosteady-*.properties
. Still, configuration files adhering to the old pattern are still considered - as long as they exist in the file system (opposed to being part of JAR or WAR files).TODO
s